Ayende @ Rahien

My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by phone or email:


+972 52-548-6969

, @ Q c

Posts: 6,026 | Comments: 44,843

filter by tags archive



It's returning an IEnumerable using yield. The caller would take out the ones they need. There's no sense in passing parameters like limit as it would the the callers' responsibility to get only the number they need. IEnumerable won't trigger data access until and unless the data is required and so the limit parameter doesn't have any use.

James Newton-King

An endId and limit seem at odds with one another.

Ayende Rahien


startId: 1

endId: 100000

limit: 100


I'd change it to IEnumerable <dictionary<int,jsondocument>

, I think key-value dependencies are better handled using Dictionary. Any ideas?


Oh no, damned HTML. Again:

I'd change it to IEnumerable<Dictionary<int,JsonDocument>> I think key-value dependencies are better handled using Dictionary. Any ideas?

Ayende Rahien


It isn't key value. It is a tuple, it isn't a set of int to json doc, it is a int & json doc.


This might be personal preference but I really don't like methods exposing tuple types. Create a type (possibly a struct) that has carries some semantics instead of the tuple.

Note that this in C#, this would obviously not be my thoughts if the language was F#, Haskell, Erlang or any other functional language.

James Newton-King

Is the collection between the startId and endId not continuous? A limit would make sense then.

Ayende Rahien


Yes, the collection may not be continuous

Ayende Rahien


This is mostly for internal API needs, it just doesn't make sense to create a type here, it wouldn't add enough meaning


Is it not also bad practice to publicly expose IEnumerable for methods like this ?

Ayende Rahien


I disagree with that quite strongly


Yeah now that I've thought it through, I'm unsure why I even said that. I read something like this on someone's blog recently and haven't had time to process it.

Dmitriy Nagirnyak

When using 'yield' the resulting items will be returned 'lazily' (delayed execution).

This might not be what the method is intended to do. I think the intention is to have the results ready after the call.

It also might have potential issue when the underlying data store is closed and the enumeration gets executed.



Martin R-L


What I do in order to use the ease of tuples and other complex generic types, and get readable code, is to at least give them a friendly name by utilizing the using statement of C#.

An example is given on my blog: http://goo.gl/ksCm

In a specific context, you can also give the type friendly method names (like e.g. Ruby's alias methods) by using extension methods that are just simple pass-throughs.

Comment preview

Comments have been closed on this topic.


No future posts left, oh my!


  1. Technical observations from my wife (3):
    13 Nov 2015 - Production issues
  2. Production postmortem (13):
    13 Nov 2015 - The case of the “it is slow on that machine (only)”
  3. Speaking (5):
    09 Nov 2015 - Community talk in Kiev, Ukraine–What does it take to be a good developer
  4. Find the bug (5):
    11 Sep 2015 - The concurrent memory buster
  5. Buffer allocation strategies (3):
    09 Sep 2015 - Bad usage patterns
View all series


Main feed Feed Stats
Comments feed   Comments Feed Stats