Ayende @ Rahien

Hi!
My name is Ayende Rahien
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by phone or email:

ayende@ayende.com

+972 52-548-6969

@

Posts: 5,947 | Comments: 44,540

filter by tags archive

Do you trust your compiler? Really trust your compiler?


There is a discussion in the alt.net mailing list right now about how far you can and should trust your compiler. I thinks that this is interesting, because this piece of code of mine is on its way to production:

public Guid Create<T>(T newEntity)
{
	using (CrmService svc = GetCrmService())
	{
		object cheatCompiler = newEntity;
		Guid guid = svc.Create((BusinessEntity) cheatCompiler);
		return guid;
	}
}

This is part an implementation of an interface in an assembly that cannot reference BusinessEntity.

I am feeling good with this.


Comments

Peter w

I can tell you one thing about the .NET 1.1 compiler: do not generate your code from an excel spreadsheet function.

If a function line has roughly 60,000 lines, it will compile, but will yield a stack overflow in execution

Jimmy Bogard

Shouldn't you constrain that generic method too? Or would that break the calling assembly?

Ayende Rahien

That would break the assembly that define the interface, that is the problem.

Stefan Wenig

you could use some defensiveness (is/throw argumentexception instead of cast), and I don't see the value of using a generic here. do you mean

Guid Create (BusinessEntity newEntity)

in the interface? then what's wrong with this?

Guid Create (object newEntity)

you might want to consider making the whole interface generic, your class could then just implement IWhatever.

Ant&#227;o

I'm sorry but I consider that bad coding. It's not the compilers fault that you accept runtime exceptions...

If you add a where statement, everything will be fine.

public Guid Create(T newEntity)

    where T : BusinessEntity

{

using (CrmService svc = GetCrmService())

{

    object cheatCompiler = newEntity;

    Guid guid = svc.Create((BusinessEntity) cheatCompiler);

    return guid;

}

}

Ayende Rahien

Anato,

Well, this doesn't really work. The interface has to reside in another assembly, and you can't add constraints to such an interface method.

Comment preview

Comments have been closed on this topic.

FUTURE POSTS

No future posts left, oh my!

RECENT SERIES

  1. RavenDB Sharding (2):
    21 May 2015 - Adding a new shard to an existing cluster, the easy way
  2. The RavenDB Comic Strip (2):
    20 May 2015 - Part II – a team in trouble!
  3. Challenge (45):
    28 Apr 2015 - What is the meaning of this change?
  4. Interview question (2):
    30 Mar 2015 - fix the index
  5. Excerpts from the RavenDB Performance team report (20):
    20 Feb 2015 - Optimizing Compare – The circle of life (a post-mortem)
View all series

RECENT COMMENTS

Syndication

Main feed Feed Stats
Comments feed   Comments Feed Stats