Ayende @ Rahien

Hi!
My name is Oren Eini
Founder of Hibernating Rhinos LTD and RavenDB.
You can reach me by phone or email:

ayende@ayende.com

+972 52-548-6969

, @ Q c

Posts: 5,971 | Comments: 44,508

filter by tags archive

Comments

Fredrik

Ha ha, it's quite subtle, but so obvious once you spot it.

Sebastian

I think there is something 'else' missing ;-)

Sam
Sam

LOL, I didn't saw it either

Marc Brooks

Not to mention the sheer lunacy of mid not being related to target in any discernable way. Ugh.

(oh, yeah, and missing else)

P.Czatrowski

Apart from missing else, what about arithmetic overflow?

I would change the line: var mid = (left + right + 1) / 2;

to this: var mid = left + (right - left + 1) / 2;

You still get the same result, but it's a little bit safer for higher values.

tobi

The bug aside, I'd use checked((left + right + 1) / 2).

Roman Boiko

Another potential problem: behavior of comparator might be not aligned with subtraction, so that

_comparator.Compare(mid-1, mid) >=0

Alex

This is really a tricky problem to spot. :) Everyone is focused on the code inside the brackets and the missing "else" is not being observed very fast.

Adam Fridental

Sorry to dissapoint, took me a second.

Anyway, I don't belive in scoping braces when they contain 1 line, it's not safer and not easier to read.. just redundant.

Comment preview

Comments have been closed on this topic.

FUTURE POSTS

  1. Paying the rent online - 2 days from now

There are posts all the way to Aug 03, 2015

RECENT SERIES

  1. Production postmortem (5):
    29 Jul 2015 - The evil licensing code
  2. Career planning (6):
    24 Jul 2015 - The immortal choices aren't
  3. API Design (7):
    20 Jul 2015 - We’ll let the users sort it out
  4. What is new in RavenDB 3.5 (3):
    15 Jul 2015 - Exploring data in the dark
  5. The RavenDB Comic Strip (3):
    28 May 2015 - Part III – High availability & sleeping soundly
View all series

Syndication

Main feed Feed Stats
Comments feed   Comments Feed Stats